vaadin / collaboration-engine

The simplest way to build real-time collaboration into web apps
https://vaadin.com/collaboration
Other
3 stars 1 forks source link

Disallow topic changes in the deactivation callback #53

Closed Legioth closed 2 years ago

Legioth commented 2 years ago

Making last-moment changes in the topic connection deactivation callback is problematic for at least two reasons:

Instead of relying on the connection deactivation callback to handle cleanup, the newly introduced EntryScope.CONNECTION setting should be used to configure the entry to be automatically removed when the connection is no longer active. This might require some changes to how data is structured in the topic, but it's the only approach that can work reliably in the long run.