vaadin / collaboration-engine

The simplest way to build real-time collaboration into web apps
https://vaadin.com/collaboration
Other
3 stars 1 forks source link

CE Binder: Improve documentation on the not working bind(ValueProvider, Setter) api #60

Open stefanuebe opened 2 years ago

stefanuebe commented 2 years ago

Is your feature request related to a use case? Please describe. Currently it is not possible to use the Binder method bind(ValueProvider<BEAN, TARGET> getter, Setter<BEAN, TARGET> setter).

This is mentioned in the binder docs, but not in the quick start nor in the api docs. Therefore, when using the quick start or simply "trying it out" you will most likely run into an issue as the reference based bind version is mostly preferred.

Describe the solution you'd like

Legioth commented 2 years ago

This is more complicated to do than what it seems like at a glance since we'd have to override the regular com.vaadin.flow.data.binder.Binder.BindingBuilder interface and then also override all methods that return that type to instead return the overriding type.

stefanuebe commented 2 years ago

Hmm, true, haven't thought about that. Then let's reduce this issue to "extend quickstart docs".