vaadin / context-menu

Vaadin ContextMenu
Apache License 2.0
11 stars 21 forks source link

Proposed fix for #28 #78

Closed mlopezFC closed 6 years ago

mlopezFC commented 6 years ago

As far as I was able to test, it seems that this solves #28 Regards.


This change is Reviewable

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

elmot commented 6 years ago

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


vaadin-context-menu-addon/src/main/java/com/vaadin/contextmenu/client/MyVMenuBar.java, line 276 at r1 (raw file):

        }
    }

Extra spaces


Comments from Reviewable

mlopezFC commented 6 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


vaadin-context-menu-addon/src/main/java/com/vaadin/contextmenu/client/MyVMenuBar.java, line 276 at r1 (raw file):

Previously, elmot (Ilia Motornyi) wrote…
Extra spaces

Done.


Comments from Reviewable

elmot commented 6 years ago

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


a discussion (no related file): Unfortunately, the fix breaks context menus completely. Steps to reproduce broken behavior:


Comments from Reviewable

elmot commented 6 years ago

There is no activity related to this PR. I am closing it. @mlopezFC, if you have another solution, please make a new PR.