vaadin / context-menu

Vaadin ContextMenu
Apache License 2.0
11 stars 21 forks source link

Compilation error with vaadin 8.6.0 #97

Closed SomMeri closed 5 years ago

SomMeri commented 5 years ago

I am getting compilation error when compiling with vaadin 8.6.0. Everything works correctly with 8.5.2.

The error:

[INFO] --- vaadin-maven-plugin:8.6.0:compile (default) @ lsps-vaadin-widgets ---
[INFO] Compiling module com.whitestein.lsps.vaadin.widgets.WidgetSet
[INFO]    Tracing compile failure path for type 'com.vaadin.contextmenu.client.MyVOverlay'
[INFO]       [ERROR] Errors in 'jar:file:/C:/Users/mna/.m2/repository/com/vaadin/vaadin-context-menu/2.1.0/vaadin-context-menu-2.1.0.jar!/com/vaadin/contextmenu/client/MyVOverlay.java'
[INFO]          [ERROR] Line 22: This static method cannot hide the instance method from VOverlay
[INFO]    [ERROR] Aborting compile due to errors in some input files

Culprit is following method in MyVOverlay.java

    public static void setApplicationConnection(ApplicationConnection ac) {
        // this.ac = ac;
        ac_static = ac;
    }

Static method with the same name appeared in main framework in VOverlay with this commit: https://github.com/vaadin/framework/commit/2f34a006ed3d98acd79c48c1a2d8fc680188053a

TatuLund commented 5 years ago

Looks like you are using v2.1.0 of the ContextMenu add-on. Have you tried v3.0.0.beta1. There has been major update with many bug fixes there. The code has been refactored and in new version the class that is failing in your case is actually removed.

pleku commented 5 years ago

Hello. Vaadin Framework 8.6 requires 3.0 beta1 or newer from context-menu. You should use our BOM to automatically get compatible version of framework and our add-ons to it https://github.com/vaadin/framework/blob/8.6/bom/pom.xml#L23

There should not be any changes, as stated in the release notes https://github.com/vaadin/context-menu/releases/tag/3.0.0.beta1. But you cannot use 2.1 since it is not compatible.

Closing as invalid.

SomMeri commented 5 years ago

Thank you for the answer. When do you plan stable release? I don't really want to use beta in production.

pleku commented 5 years ago

We will take a look at #96 which might be a regression in 3.0, and then release 3.0.0 this or next week.

pleku commented 5 years ago

@SomMeri #96 is not even for 3.0 so we can do a final release this week.

SomMeri commented 5 years ago

Thank you, that is great. Btw, I can wait two weeks. I just needed to know whether it will be sometime soon which it is.