search

vaadin / copilot

0 stars 0 forks source link

Change the shortcut to something that you do not accidentally hit while using an application #10

Closed Artur- closed 5 months ago

Artur- commented 5 months ago

When you type a lot of special characters or capital characters you might very well end up pressing shift twice. Then copilot pops up and BAM, it is in the way.

The shortcut should be such that you do not accidentally ever trigger it during application testing

probert94 commented 5 months ago

Another problem related to this is that if you keep pressing shift it keeps toggling the copilot. So the repeat flag is probably ignored.

TatuLund commented 5 months ago

Good example is Selection Grid where shift + space is used for toggling multi selection, also shift + mouse click

https://vaadin.com/directory/component/selection-grid

TatuLund commented 5 months ago

As almost any key combo can conflict with the application, there should be way to configure it.

Artur- commented 5 months ago

shift + space is used for toggling multi selection

This does not activate copilot though

shift + mouse click

This seems to be an oversight when a click in between does not abort activation

finaris-cs commented 5 months ago

Maybe there is a setting to switch off vaadin copilot? The accidental triggering when writing capital letters is a bit annoying.

Artur- commented 5 months ago

We made the following changes:

  1. Change the activation shortcut to shift+(ctrl+ctrl) or shift+(cmd+cmd)
  2. Added a vaadin.copilot.enable property you can set to false to prevent copilot from showing up
  3. Removed copilot from 24.3.5 to avoid issues. It will be in 24.4
  4. Added a possibility to disable the shortcut