Copilot Routes Navigation not working

DarioViva42 commented 2 months ago

Description of the Bug

When I use copilot to see a listing of all routes this is what I see:

Now, clicking on the marked links does navigate to the correct view. this is a helpful feature. but when configuring vaadin.url-mapping to not use the root for vaadin routes this no longer works. the copilot still navigates to the routes as if vaadin.url-mapping is not set. Also hovering over the links, normally showing the url of the link, does not show the expected url.

In the demonstration project I use /vaadin/* as the mapping.

vaadin.url-mapping=/vaadin/*

Expected Behavior

I would expect copilot to honor the mapping. Also I expect to see localhost:8080/vaadin/hello-world instead of localhost:8080/vaadin/ when hovering over the link.

Minimal Reproducible Example

https://github.com/DarioViva42/vaadinHistoryBug/tree/navigation

The repo was used as a demonstration for another issue, but branch navigation can be used to demonstrate this issue.

Versions

Vaadin Flow Framework Version: 24.4.7
Copilot Version: 24.4.12
Browser Information: Firefox 129.0.2

DarioViva42 commented 2 months ago

@czp13 when will the fix be shipped?

Artur- commented 2 months ago

It will be in the next release

czp13 commented 2 months ago

@DarioViva42 It was just autoclosed because the above PR was merged.

As Artur said in next release this shall be fixed, and releases are quite frequent if you check these:

https://github.com/vaadin/copilot/releases

So hopefully soon you can test it!

DarioViva42 commented 2 months ago

@czp13

[…] because the above PR was merged.

I don't see the PR. Copilot is closed source as far as I know, so I can not see what changes you committed. But good to hear its fixed that quickly.

czp13 commented 2 months ago

I don't see the PR. Copilot is closed source as far as I know, so I can not see what changes you committed. But good to hear its fixed that quickly. Oh, okey, I thought at least some kind of info about a PR that was merged is visible in the issue ticket. Yes, Copilot is closed source.

Glad to hear, take care.

vaadin-bot commented 2 months ago

This ticket/PR has been released with Vaadin 24.5.0.alpha15 and is also targeting the upcoming stable 24.5.0 version.

vaadin / copilot