Support Spring initializer project structure

szolo commented 4 years ago

Steps to reproduce

Open "File-New-Project" menu.
Select "Spring Initializr", proceed to the next steps.
In "Dependencies" step select "Web-Vaadin", proceed to the next steps.

spring-initializer-project

Actual behavior

Designer can't be used in this project structure. Designer preferences doesn't load correctly.

Expected behavior

Designer can be used in this project structure.

IDE, Designer and OS version

IntelliJ IDEA Ultimate 2019.3, Designer 4.3.12, Windows 10.

Additional information

Please notice that in this project structure webjar dependencies are not excluded and this is fine. See https://vaadin.slack.com/archives/C6X43FE8M/p1582041737273800.

Peppe commented 4 years ago

@mstahv any ideas how Initilzr projects are different than those you get from vaadin.com/start, in a structural way? Something that might break our assumptions that we might have in Designer.

mstahv commented 4 years ago

Two things come to my mind:

Spring Initializr is not adding vaadin-maven-plugin currently for production mode build, we should discuss that with Spring Boot team at some point. Already discussed earlier, but it became less critical as app can again be started without plugin (in dev mode)
frontend folder don't exists

Otherwise those should be pretty much the same.

Peppe commented 4 years ago

Should the Initilizr project add the frontend folder? It feels like quite central in Vaadin projects nowadays. We can fix it on Designer side as well, but it feels like a wrong fix if Vaadin projects need the folder anyhow.

mstahv commented 4 years ago

I'd be quite surprised if Spring Initializr team would want to add non-standard frontend folder to the root of the project (against common Java/Maven conventions). But it can be tried of course.

stale[bot] commented 4 years ago

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a few things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

Check if the issue is still valid for the latest version. There are many duplicates in our issue tracker, so it is possible that the issue is already tackled.
Provide more details how to reproduce the issue.
Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

vaadin / designer