DnD doesn't work in beverage starter

szolo commented 4 years ago

Steps to reproduce

Clone repo https://github.com/vaadin/beverage-starter-flow.
Open existing design or create the new one.
Try to drag from palette to canvas for both embedded browser and external Chrome.

Actual behavior

DnD from palette to canvas doesn't work.

Expected behavior

DnD from palette to canvas works.

IDE, Designer and OS version

Designer 4.3.12, Windows 10, IntelliJ IDEA Ultimate 2019.3.

web-padawan commented 4 years ago

I have tried with https://github.com/vaadin/beverage-starter-flow/tree/v14 and master branches, and I was unable to reproduce this.

Drag and drop works for both existing design (reviews-list) and new design.

If that's a random issue and you encounter it again, would be nice to look at the DevTools. In that case, please ping me so we could investigate.

szolo commented 4 years ago

This happens because Polyfill (webcomponentjs) dependency has been removed from the V15 (leads to wrong import line in Designer). For now they restored it, but eventually it will be cleaned (old browsers won't be supported by V15).

After discussion with @web-padawan it seems that for V15 we need to serve Polyfill from Designer itself while for the previous platform versions we still can use it from project.

Peppe commented 4 years ago

Does this mean that this only happens in the embedded browser, due to it not having native web components support, and not in external Chrome?

szolo commented 4 years ago

@Peppe it happens because V15 projects are missing Polyfill dependencies. We need polyfills for the external preview. Fir the V15 not having polyfills is okay, because only the modern browsers are supported. We just need to have this check in code "if project is using V15 do not insert polyfills import".

Webcomponentjs is the polyfill import by the way.

stale[bot] commented 3 years ago

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a few things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

Check if the issue is still valid for the latest version. There are many duplicates in our issue tracker, so it is possible that the issue is already tackled.
Provide more details how to reproduce the issue.
Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

vaadin / designer