vaadin / designer

Public repository for Vaadin Designer
https://vaadin.com/designer
15 stars 3 forks source link

Polymer properties should be shown in the designer #2305

Open stefanuebe opened 4 years ago

stefanuebe commented 4 years ago

Currently, when a Polymer property is referenced somewhere (e.g. [[item.someProperty]]), this is only shown when adding that to an element (e.g. creating a text node or text field setting that as value or placeholder or whatever).

After reopening the designer, that property is no longer shown. That is unpleasant, since one one hand it is no longer obvious, that the property is referenced there and on the other hand I have no visual feedback about styling or theming this particular part any more.

Steps to reproduce

  1. Add a span.
  2. Add some example property access as text, for instance [[myProperty]].
  3. That example will appear in the canvas.
  4. Reload the page.
  5. The text is now not shown anymore.

Actual behavior

See above.

Here an example with a text field, obtaining the placeholder from a property.

  1. Visual state after adding and setting the placeholder image

  2. After reloading the editor (or reopening it) image

Expected behavior

The property access text fragments should also be visible as seen in the first image.

If there is a need to not have them shown (for instance to see how an empty value would look like), a global switch could be integrated to turn the showing on and off.

IDE, Designer and OS version

IntelliJ, Designer 4.5.0, Chrome designer, Windows 10

Peppe commented 4 years ago

This seems like a bug and should be fixed.

However, I recommend that leaving data binding to the java side. There is benefits of doing all the static in Designer and all dynamic in Java. When you start mixing the two, you will run into problems. So e.g. label that doesn't change is good to define in Designer, while value would be defined in Java.

stefanuebe commented 4 years ago

If you're designing web components without any Java, you'll have to do it :) and you know, what can be done will be done by someone :D

stale[bot] commented 3 years ago

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a few things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!