search

vaadin / designer

Public repository for Vaadin Designer
https://vaadin.com/designer
15 stars 3 forks source link

Designer property editor undo with ctrl-z fails #807

Closed vaadin-bot closed 8 years ago

vaadin-bot commented 8 years ago

Originally by @OlliTietavainenVaadin

OS: Windows 10 Pro Eclipse: Luna SR2

ctrl-z to undo doesn't always work in the Properties editor. Steps to reproduce:

  1. Create a design with a blank template
  2. Add a VerticalLayout and select it
  3. Edit Width field to something else than the default
  4. Click the Description field in the Properties editor so it gets focus
  5. Press Ctrl-z -> nothing happens, expected: Width is returned to the default
  6. Click on Visible field in the Properties editor
  7. Press Ctrl-z (twice if you toggled visibility) -> Undo is done correctly

Imported from https://dev.vaadin.com/ issue #19311

vaadin-bot commented 8 years ago

Originally by @emarc

This is actually how property editors work in Eclipse, as far as I know - unintuitive or not... The idea, as I understand it, is that you can only undo the (uncommited) changes you have in the active editor, until you "commit" those values.

We might revisit this usability topic in the future, but for now, let's keep this behaviour.