Some Hilla component examples are not standalone

vaadin / docs

Official documentation for Vaadin and Hilla.

https://vaadin.com/docs

Other

27 stars 172 forks source link

Some Hilla component examples are not standalone #2730

Open LawrenceDLockhart opened 10 months ago

LawrenceDLockhart commented 10 months ago

Some of the Hilla/React Basics Tutorial component examples include dependencies or style references which the user will not have rendering them unresolvable. One example is the confirmDialogBasicStyles import in the Confirm Dialog component:

Perhaps we could either

include the file
include the instruction to add the file
or in the case of missing styles, inline the styles

jouni commented 10 months ago

Yeah, that file should be added to the example sources.