vaadin / docs

Official documentation for Vaadin and Hilla.
https://vaadin.com/docs
Other
29 stars 186 forks source link

fix: do not use static drop mode for grids in dnd examples #3444

Closed tomivirkki closed 4 months ago

tomivirkki commented 4 months ago

Currently, all the grids in the drag & drop examples section use static drop mode values. This means that the drop indicator is shown for them even while dragging unrelated things like text or rows from another example:

https://github.com/vaadin/docs/assets/1222264/f780e578-fe75-41af-b1ed-4ae7725f8753

This PR fixes the issue by updating the examples to dynamically apply the drop mode when a row drag starts and clear the drop mode when the row drag ends.

Related to https://github.com/vaadin/flow-components/issues/6306