vaadin / docs

Official documentation for Vaadin and Hilla.
https://vaadin.com/docs
Other
30 stars 184 forks source link

lumoImports property of theme.json is not documented #433

Closed Haprog closed 4 days ago

Haprog commented 3 years ago

The lumoImports property should probably be documented at https://vaadin.com/docs/latest/ds/customization/custom-theme-configuration

For example one use case for this feature is to import Lumo badge styles to be able to use Badge. After the docs for lumoImports have been added, the Badge page should also be updated to link to it so the users can find out how to import the badge styles which is now not covered on the Badge page.

Implementation source code of lumoImports (for reference): https://github.com/vaadin/flow/search?q=lumoImports&type=code

Some related discussion in internal Slack: https://vaadin.slack.com/archives/CQUQWJ4KU/p1616759094157900

web-padawan commented 1 year ago

There are some mentions now in the following pages:

However, the original page still lacks mention of lumoImports.

web-padawan commented 4 days ago

The lumoImports documentation was added in #2071 and it's now under a dedicated Theme Configuration section. Closing.