search

vaadin / eclipse-plugin

Vaadin Plugin for Eclipse
https://vaadin.com/eclipse
16 stars 8 forks source link

Handle single notification correctly #744

Closed tsuoanttila closed 7 years ago

tsuoanttila commented 7 years ago

Fixes #708

This change is Reviewable

hesara commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

com.vaadin.integration.eclipse/src/com/vaadin/integration/eclipse/notifications/model/NotificationsService.java, line 489 at r1 (raw file):

            Object notifications = object.get(NOTIFICATIONS);
            List<Notification> list = new ArrayList<Notification>();
            if (notifications instanceof JSONArray) {

could use a comment on why we need to do this

Comments from Reviewable

hesara commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable