vaadin / expense-manager-demo

Progressive Web App (PWA) demo using Vaadin components
https://vaadin.com/components
Apache License 2.0
360 stars 142 forks source link

fix flex in dialog content on ie11 #109

Closed manolo closed 6 years ago

manolo commented 6 years ago

Fixes #108

This change is Reviewable

web-padawan commented 6 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed, 1 unresolved discussion (waiting on @manolo)


src/shared-styles.html, line 34 at r1 (raw file):


      [part="content"] {
        display: 1 0 auto;

incorrect property value


Comments from Reviewable

yuriy-fix commented 6 years ago

I have reimplemented the solution in scope of this PR.

web-padawan commented 6 years ago

Reviewed 3 of 3 files at r2. Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

tomivirkki commented 6 years ago

screen shot 2018-06-21 at 12 49 54

This PR fixes the issue with IE but it breaks the layout for Edge (screenshot above)

yuriy-fix commented 6 years ago

After long investigation, we came up with the decision to use display: flex on overlay parts.


Review status: 1 of 3 files reviewed, all discussions resolved (waiting on @web-padawan)


Comments from Reviewable

tomivirkki commented 6 years ago
:lgtm:

Reviewed 1 of 3 files at r2, 2 of 3 files at r3. Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable