Closed manolo closed 6 years ago
src/expense-editor.html, line 188 at r1 (raw file):
*/ _getDialogChild(selector) { return this.$.dialog.$.overlay.$.content.root.querySelector(selector);
Should be "shadowRoot" instead of "root"
Comments from Reviewable
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.
src/expense-editor.html, line 188 at r1 (raw file):
Should be "shadowRoot" instead of "root"
Done.
Comments from Reviewable
Reviewed 1 of 2 files at r1, 2 of 2 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion.
src/expense-editor.html, line 77 at r2 (raw file):
<div class="file-list"> <div class="receipt-wrapper"> <img src$="[[rootPath]][[_expense.receipt]]" alt="Receipt" hidden$="[[!_expense.receipt]]">
why has the ` been removed
Comments from Reviewable
Review status: all files reviewed at latest revision, 2 unresolved discussions.
src/expense-editor.html, line 77 at r2 (raw file):
why has the ` been removed
sorry, I mean "rootPath". It is needed to work with prpl-server, and adds the "/es6-bundled/" folder prefix here
Comments from Reviewable
Review status: all files reviewed at latest revision, 2 unresolved discussions.
src/expense-editor.html, line 77 at r2 (raw file):
sorry, I mean "rootPath". It is needed to work with prpl-server, and adds the "/es6-bundled/" folder prefix here
So we need a function here, because it's added also when url is data:...
will find a solution
Comments from Reviewable
Review status: 2 of 3 files reviewed at latest revision, 2 unresolved discussions.
src/expense-editor.html, line 77 at r2 (raw file):
So we need a function here, because it's added also when url is `data:...` will find a solution
Done.
Comments from Reviewable
Reviewed 1 of 1 files at r3. Review status: all files reviewed at latest revision, 1 unresolved discussion.
Comments from Reviewable
Reviewed 1 of 2 files at r1, 1 of 2 files at r2, 1 of 1 files at r4. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
Reviewed 1 of 1 files at r4. Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
This change is