fix: run grid dnd filters on dropmode and draggable change

vaadin / flow-components

Java counterpart of Vaadin Web Components

82 stars 63 forks source link

fix: run grid dnd filters on dropmode and draggable change #6339

Closed tomivirkki closed 4 weeks ago

tomivirkki commented 4 weeks ago

Description

Run getDataCommunicator().reset(); when "drop mode" changes dynamically because the drop filters only apply if drop mode is non-null.
Run getDataCommunicator().reset(); when "rows draggable" changes dynamically because the drag filters apply if the rows are draggable.

Fixes https://github.com/vaadin/flow-components/issues/6310

Type of change

Bugfix

sonarcloud[bot] commented 4 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

vaadin-bot commented 4 weeks ago

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 23.5, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick c352cb9c2205502421b7a57a5ac4910ce26f99d5 error: could not apply c352cb9c22... fix: run grid dnd filters on dropmode and draggable change (#6339) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".

vaadin-bot commented 4 weeks ago

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 14.11, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick c352cb9c2205502421b7a57a5ac4910ce26f99d5 error: could not apply c352cb9c22... fix: run grid dnd filters on dropmode and draggable change (#6339) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".

vaadin-bot commented 4 weeks ago

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 23.4, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick c352cb9c2205502421b7a57a5ac4910ce26f99d5 error: could not apply c352cb9c22... fix: run grid dnd filters on dropmode and draggable change (#6339) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".