search

vaadin / flow-components

Java counterpart of Vaadin Web Components
81 stars 63 forks source link

fix: make setRequired also activate required validation #6347

Closed vursen closed 3 weeks ago

vursen commented 3 weeks ago

Description

Finding from #6346

The PR fixes a bug where the setRequired method didn't activate the required validation for number fields, unlike setRequiredIndicatorVisible which did.

Type of change

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

vaadin-bot commented 3 weeks ago

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick d76dec40e75af66d0037b8f702f13af2ce333904 error: could not apply d76dec40e7... fix: make setRequired also activate required validation (#6347) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".

vaadin-bot commented 3 weeks ago

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick d76dec40e75af66d0037b8f702f13af2ce333904 error: could not apply d76dec40e7... fix: make setRequired also activate required validation (#6347) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".