search

vaadin / flow-components

Java counterpart of Vaadin Web Components
100 stars 66 forks source link

chore: Bump jakarta.servlet:jakarta.servlet-api from 5.0.0 to 6.1.0 #6367

Closed dependabot[bot] closed 3 months ago

dependabot[bot] commented 3 months ago

Bumps jakarta.servlet:jakarta.servlet-api from 5.0.0 to 6.1.0.

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

knoobie commented 3 months ago

Don't! :) This is Jakarta 11

sissbruecker commented 3 months ago

@knoobie Thanks for the heads up! I checked in the Flow repo, where 6.0.0 is already in use: https://github.com/vaadin/flow/blob/ba2400f917d40aa3df6c61e2445b5c2bfc8c5e6a/pom.xml#L229-L233. Will double-check internally though, I honestly don't have a good understanding about the impact.

knoobie commented 3 months ago

From the release notes of 24.4:

Vaadin Flow requires Java Servlet API 6 and Java 17 or newer.

Servlet 6 falls under Jakarta 10; Servlet 6.1 falls under Jakarta 11 (to be released the upcoming months) and is not supported by e.g. Spring and other in the ecosystem

I had a similar headsup with @mcollovati in the flow repo some days ago

mcollovati commented 3 months ago

I can confirm what @knoobie says. In Flow, we reverted and closed bumps for several Jakarta 11 dependencies, e.g. https://github.com/vaadin/flow/pull/19448, https://github.com/vaadin/flow/pull/19435

sissbruecker commented 3 months ago

Thanks for the clarification, let's close this one then.

dependabot[bot] commented 3 months ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.