search

vaadin / flow-components

Java counterpart of Vaadin Web Components
101 stars 66 forks source link

test: isolate logger mocking into respective tests #6814

Closed sissbruecker closed 1 week ago

sissbruecker commented 1 week ago

https://github.com/vaadin/flow-components/pull/6669 introduced static mocking of LoggerFactory in LoginFormTest, however that seems to cause flaky tests, such as the failure here on a PR for Upload.

Moving the mocking into the respective test methods seems to help.

sissbruecker commented 1 week ago

Thanks, also updated LoginOverlayTest as it uses the same setup / test cases.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud