search

vaadin / flow

Vaadin Flow is a Java framework binding Vaadin web components to Java. This is part of Vaadin 10+.
Apache License 2.0
605 stars 166 forks source link

Vaadin should detect `overrides` section changes in `package.json` #12682

Open haijian-vaadin opened 2 years ago

haijian-vaadin commented 2 years ago

Description of the bug

npm 8.3.0 delivers the overrides feature, which can be used for locking dependency versions. However, when a user modifies the overrides section manually, Vaadin doesn't detect the change.

Download a starter app from start.vadin

  1. Run mvn spring-boot:run
  2. Edit package.json and add an override like "json-schema": ">=0.4.0"
  3. Run mvn spring-boot:run

If the original npm installation used 0.3.0 like in my app, it will still use 0.3.0. This is only because

Skipping `npm install` because the frontend packages are already installed in the folder '.../node_modules' and the hash in the file '.../node_modules/.vaadin/vaadin.json' is the same as in 'package.json'

Expected behavior

Vaadin detects the changes in the overrides section.

Minimal reproducible example

Download a starter app from start.vadin

Versions

Artur- commented 1 year ago

Isn't this fixed a long time ago?