search

vaadin / flow

Vaadin Flow is a Java framework binding Vaadin web components to Java. This is part of Vaadin 10+.
Apache License 2.0
592 stars 163 forks source link

npm deprecated warnings in logs #15512

Open tarekoraby opened 1 year ago

tarekoraby commented 1 year ago

Description of the bug

Running a freshly downloaded Flow or Hilla app, I see the following in the logs

npm WARN deprecated rollup-plugin-terser@7.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-terser
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead

Expected behavior

No warnings are shown when starting on the latest and greatest Vaadin version

Minimal reproducible example

Run a Flow or Hilla project from start.vaadin.com

Versions

Artur- commented 1 year ago 
├─┬ workbox-build@6.5.0
│ ├─┬ rollup-plugin-terser@7.0.2

https://github.com/GoogleChrome/workbox/issues/3136

├─┬ @rollup/plugin-replace@3.1.0
│ ├─┬ magic-string@0.25.9
│ │ └── sourcemap-codec@1.4.8
├─┬ @vitejs/plugin-react@2.2.0
│ ├─┬ magic-string@0.26.7
│ │ └── sourcemap-codec@1.4.8 deduped
Artur- commented 1 year ago

magic-string was fixed in 0.27 a year ago...

knoobie commented 1 year ago

Is workbox for anything used except service worker? If so, shouldn't this be only added if service worker / PWA annotation is used? I've seen this two warnings even for apps with no PWA support at all.

tarekoraby commented 1 year ago

I can still see the warnings in the logs with 24.0.0.alpha8. The linked workbox issue is still not fixed.

Artur- commented 1 year ago

workbox is fixed in #16934 but transform-ast still depends on an old version of magic-string

Artur- commented 1 year ago

Seems like a unreasonably large effort to get rid of all deprecation warnings.