search

vaadin / flow

Vaadin Flow is a Java framework binding Vaadin web components to Java. This is part of Vaadin 10+.
Apache License 2.0
604 stars 165 forks source link

WebComponentExporter: API to manage including vaadin-connection-indicator #19729

Open jentelibaers opened 1 month ago

jentelibaers commented 1 month ago

Description of the issue When exposing a part of a vaadin application as a webcomponent via the WebComponentExporter, the vaadin-connection-indicator tag is automatically added to the body of the html page that includes the web component. This could be considered as unwanted behaviour as this impacts the embedding html page showing the indicator on top of the page.

Expected When a vaadin application uses the vaadin-connection-indicator and also exports web components, the vaadin-connection-indicator should not be added automatically to the page that uses any of the exported web components. A solution might be to make this configurable in the WebComponentExporter to allow managing this.

Vaadin / Flow version: 23.3.34

samie commented 1 month ago

Agreed. Recently encountered this the CORS sample application https://github.com/samie/vaadin-cors-sample In cases like this it would sense to present the loading indicator inside the application web component than the page.