Revert "feat: Support top-level await"

vaadin / flow

Vaadin Flow is a Java framework binding Vaadin web components to Java. This is part of Vaadin 10+.

Apache License 2.0

619 stars 167 forks source link

Revert "feat: Support top-level await" #19947

Closed Artur- closed 2 months ago

Artur- commented 2 months ago

Reverts vaadin/flow#18772

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 2 months ago

Test Results

1 135 files ± 0 1 135 suites ±0 1h 28m 48s :stopwatch: + 1m 19s 7 391 tests - 2 7 341 :white_check_mark: - 2 50 :zzz: ±0 0 :x: ±0 7 723 runs - 32 7 663 :white_check_mark: - 32 60 :zzz: ±0 0 :x: ±0

Results for commit ff5f57e7. ± Comparison against base commit 20623f59.

This pull request removes 2 tests.

``` com.vaadin.viteapp.BasicsIT ‑ toplevelAwaitWorks[any_Chrome_] com.vaadin.viteapp.ProductionBasicsIT ‑ toplevelAwaitWorks[any_Chrome_] ```

mshabarov commented 2 months ago

Reverted as top level await causes problems that hard to diagnose and solve.