fix: forward with optional callback

vaadin / flow

Vaadin Flow is a Java framework binding Vaadin web components to Java. This is part of Vaadin 10+.

Apache License 2.0

619 stars 167 forks source link

fix: forward with optional callback #19959

Closed tepi closed 1 month ago

tepi commented 2 months ago

Fixes https://github.com/vaadin/flow/issues/19794 Fixes https://github.com/vaadin/flow/issues/19822

Also fixes https://github.com/vaadin/flow/issues/19813 in a more coherent way. Relevant test is com.vaadin.flow.uitest.ui.PreserveOnRefreshForwardingIT

github-actions[bot] commented 2 months ago

Test Results

1 137 files + 2 1 137 suites +2 1h 25m 27s :stopwatch: - 7m 28s 7 397 tests + 4 7 347 :white_check_mark: + 4 50 :zzz: ±0 0 :x: ±0 7 757 runs +33 7 697 :white_check_mark: +33 60 :zzz: ±0 0 :x: ±0

Results for commit 73753abe. ± Comparison against base commit c615be5b.

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vaadin-bot commented 1 month ago

Hi @tepi and @tepi, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick 62cae89b177b363cc926b7a6e5f4efc82fff4d90 error: could not apply 62cae89b17... fix: forward with optional callback (#19959) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".

vaadin-bot commented 1 month ago

This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version.