fix: Also take into account the application.properties value

vaadin / flow

Vaadin Flow is a Java framework binding Vaadin web components to Java. This is part of Vaadin 10+.

Apache License 2.0

609 stars 167 forks source link

fix: Also take into account the application.properties value #19966

Closed caalador closed 1 week ago

caalador commented 1 week ago

When checking for react enable also look if we have a application.properties with the vaadin.react.enable flag.

This is especially for production build when only application.properties has react disabled.

Touches #19951 and #19911

github-actions[bot] commented 1 week ago

Test Results

1 135 files ±0 1 135 suites ±0 1h 26m 49s :stopwatch: - 1m 25s 7 395 tests +2 7 345 :white_check_mark: +2 50 :zzz: ±0 0 :x: ±0 7 754 runs +5 7 698 :white_check_mark: +9 56 :zzz: - 4 0 :x: ±0

Results for commit de06dd12. ± Comparison against base commit 2c25b821.

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud