vaadin / flow

Vaadin Flow is a Java framework binding Vaadin web components to Java. This is part of Vaadin 10+.
Apache License 2.0
609 stars 167 forks source link

fix: ensure session is registered with Hotswapper #19979

Closed mcollovati closed 1 week ago

mcollovati commented 1 week ago

Description

VaadinSession references are registered in Hotswapper in a session init listener. However, the listener might not always been invoked, for example if the HTTP session is serialized and deserialized on server restart. This change registers a UI init listener to make sure VaadinSession reference is also registered for existing sessions.

Fixes #19973

Type of change

Checklist

Additional for Feature type of change

github-actions[bot] commented 1 week ago

Test Results

1 137 files  ± 0  1 137 suites  ±0   1h 9m 58s :stopwatch: - 11m 35s 7 399 tests ± 0  7 349 :white_check_mark: ± 0  50 :zzz: ±0  0 :x: ±0  7 759 runs  +39  7 699 :white_check_mark: +39  60 :zzz: ±0  0 :x: ±0 

Results for commit adbfe547. ± Comparison against base commit bf420c43.

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vaadin-bot commented 3 days ago

This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version.