vaadin / flow

Vaadin Flow is a Java framework binding Vaadin web components to Java. This is part of Vaadin 10+.
Apache License 2.0
619 stars 167 forks source link

Open source Flow apps don't check Control Center's feature flag #20013

Closed mshabarov closed 1 month ago

mshabarov commented 1 month ago

Description of the bug

Vaadin Flow does license checking for product vaadin-commercial-cc-client only when it spots any commercial component in the project, which is wrong, as a project can fairly be an open source project that is deployed with Control Center.

Instead, Flow should:

This would make a call to server when it's really needed.

Expected behavior

Flow should check this product for open source apps.

Minimal reproducible example

  1. Add
    <dependency>
    <groupId>com.vaadin</groupId>
    <artifactId>control-center-starter</artifactId>
    <version>1.0-SNAPSHOT</version>
    </dependency>

    to a spring skeleton starter

  2. Build open source Vaadin app for production and see that Flow doesn't make this call.

Versions

vaadin-bot commented 1 month ago

This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version.