vaadin / flow

Vaadin Flow is a Java framework binding Vaadin web components to Java. This is part of Vaadin 10+.
Apache License 2.0
619 stars 167 forks source link

fix: client route collisions #20327

Closed caalador closed 3 weeks ago

caalador commented 3 weeks ago

Fix the client server route collision to not take into account client layouts as they are not route targets.

For instance

  {
    "route": "flow",
    "params": {},
    "children": [
      {
        "route": "hello-hilla",
        "menu": {
          "title": "Hello React in Flow Layout"
        },
        "title": "Hilla in Flow",
        "flowLayout": true,
        "params": {}
      }
    ]
  },

Collision on flow is wrong as the actual existing route is only flow/hello-hilla and thus should not match against a server route flow

github-actions[bot] commented 3 weeks ago

Test Results

1 142 files  ± 0  1 142 suites  ±0   1h 24m 29s ⏱️ +53s 7 474 tests + 2  7 424 ✅ + 2  50 💤 ±0  0 ❌ ±0  7 801 runs   - 30  7 741 ✅  - 30  60 💤 ±0  0 ❌ ±0 

Results for commit 2cf7e0e6. ± Comparison against base commit abddf7b8.

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
22 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vaadin-bot commented 1 week ago

This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version.