search

vaadin / flow

Vaadin Flow is a Java framework binding Vaadin web components to Java. This is part of Vaadin 10+.
Apache License 2.0
619 stars 167 forks source link

test: fix test ordering #20466

Closed mcollovati closed 2 days ago

mcollovati commented 3 days ago

Flow test suite contains some modules that define multiple pom files in the same folder. When executing Maven with -pl option pointing to such a folder, Maven will pick by default the pom file that is placed as the first in the parent pom's modules section. This causes some poms to be executed twice and others to not be executed at all. This change fixes ordering of modules, to ensure all are execute in validation workflow.

github-actions[bot] commented 3 days ago

Test Results

1 156 files  +10  1 156 suites  +10   1h 41m 22s ⏱️ + 7m 49s 7 498 tests + 9  7 445 ✅ + 6  53 💤 +3  0 ❌ ±0  7 876 runs  +17  7 813 ✅ +14  63 💤 +3  0 ❌ ±0 

Results for commit 1b5717fe. ± Comparison against base commit 05f03774.

This pull request skips 2 tests. ``` com.vaadin.flow.uitest.multimodule.ui.FrontendLiveReloadIT ‑ modifyMetaInfFrontendFile[any_Chrome_] com.vaadin.flow.uitest.multimodule.ui.FrontendLiveReloadIT ‑ modifyMetaInfResourcesFrontendFile[any_Chrome_] ```

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 3 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud