search

vaadin / flow

Vaadin Flow is a Java framework binding Vaadin web components to Java. This is part of Vaadin 10+.
Apache License 2.0
618 stars 167 forks source link

Please quiet down the 14.2 frontend compilation #8104

Open jflamy opened 4 years ago

jflamy commented 4 years ago

When developping, we sort of know that Vaadin will be running in debug mode.

Also, the many "=============" and "-------------------" lines give the output a "first-year programming course-just-learned-about-printf-this-is-cool" feeling that does not fit with the rest of the well-polished product.

Suggestion: add a "verboseLevel" configuration option, with 0 meaning error messages only.

Also If I'm running an embedded Tomcat or Jetty and I change the port, it is pointlessly annoying to be given a wrong URL in the instructions.

jflamy commented 4 years ago

And while I'm at it, ANSI escape codes for color look annoying in the Eclipse console window. Another option to shut them off would be nice. Will accept "ok, boomer" as an answer, even though I don't quite qualify :-)

juhopiirainen commented 4 years ago

Thanks for the ticket @jflamy. I move this to the Flow team for evaluation.

pleku commented 4 years ago

Will accept "ok, boomer" as an answer, even though I don't quite qualify :-)

I don't quite qualify for giving that response either ;)

Thanks for the feedback. I've touched the log output lately for 14.2 and other versions to make it less verbose for the frontend side and to unify the output for the detected configuration used like "You are running development mode...". These were packed inside single ====... intentionally to stand out a bit, but there should be only one output with these.

The message for app is running was intended for more newbie users and even mentions that the port not be valid. This is only done in development mode and yes it is of no information to most users, but for new users we have discovered issues in trying to understand what do and what to make of the overwhelming log output.

Suggestion: add a "verboseLevel" configuration option, with 0 meaning error messages only.

Using defaultLogLevel=warning should be enough for you @jflamy I think ? How to apply it dends on the logging facade used though (like slf4j). The intention is anyway that the above mentioneed output is given at level info, so using warning should work for you.

I'll take a look at this after finishing some ongoing things.

jflamy commented 4 years ago

I use slf4j with logback but this appears to be written straight to stdout — or not caught by my config. I already have a few Vaadin loggers bumped up to error because warning is used abusively — will open other tickets.

Kindly provide your config for this one?