chore: Add a feature flag

[mshabarov]

Depends on https://github.com/vaadin/flow/pull/17385

[czp13]

I cannot accept, or approve this yet, as I want to test the addon (I feel/assume probably UI-s are not reachable with this change). Plus after I built 24.2-Snapshot I had this error:

[ERROR] Malformed \uxxxx encoding.
java.lang.IllegalArgumentException: Malformed \uxxxx encoding.

Probably this is a local/env error.

[mshabarov]

I expected that VaadinContext is always available when the form filler is initialised on with a layout component.

[czp13]

I dunno how it break, but I needed to delete this file: rm -rf /Users/pczuczor/.m2/repository/com/vaadin/vaadin-icons-testbench/24.2-SNAPSHOT/resolver-status.properties rm -rf /Users/pczuczor/.m2/repository/com/vaadin/vaadin-rich-text-editor-flow-parent/24.2-SNAPSHOT/resolver-status.properties

This contained the malformed file, which thrown the exception preventing my build to succedd (mvn clean install):

 default -> throw new IllegalArgumentException("Malformed \\uxxxx encoding.");

Hopefully it is just my env, my maven and not a problem with the build, or code repo (probably local maven related problem). But shared in case of interest.

[czp13]

Now the build goes further, but this fails:

Execution default of goal com.vaadin:vaadin-maven-plugin:24.2-SNAPSHOT:prepare-frontend failed: An API incompatibility was encountered while executing com.vaadin:vaadin-maven-plugin:24.2-SNAPSHOT:prepare-frontend: java.lang.AbstractMethodError: com/vaadin/flow/plugin/base/PluginAdapterBase.isPrepareFrontendCacheDisabled()Z
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>com.vaadin:vaadin-maven-plugin:24.2-SNAPSHOT
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/Users/pczuczor/.m2/repository/com/vaadin/vaadin-maven-plugin/24.2-SNAPSHOT/vaadin-maven-plugin-24.2-SNAPSHOT.jar
[ERROR] urls[1] = file:/Users/pczuczor/.m2/repository/com/vaadin/flow-maven-plugin/24.2-SNAPSHOT/flow-maven-plugin-24.2-SNAPSHOT.jar
[ERROR] urls[2] = file:/Users/pczuczor/.m2/repository/com/vaadin/flow-plugin-base/24.2-SNAPSHOT/flow-plugin-base-24.2-SNAPSHOT.jar
[ERROR] urls[3] = file:/Users/pczuczor/.m2/repository/com/vaadin/flow-server/24.2-SNAPSHOT/flow-server-24.2-SNAPSHOT.jar
[ERROR] urls[4] = file:/Users/pczuczor/.m2/repository/com/vaadin/flow-push/24.2-SNAPSHOT/flow-push-24.2-SNAPSHOT.jar
[ERROR] urls[5] = file:/Users/pczuczor/.m2/repository/com/vaadin/external/atmosphere/atmosphere-runtime/3.0.3.slf4jvaadin1/atmosphere-runtime-3.0.3.slf4jvaadin1.jar
[ERROR] urls[6] = file:/Users/pczuczor/.m2/repository/com/vaadin/servletdetector/throw-if-servlet3/1.0.2/throw-if-servlet3-1.0.2.jar
[ERROR] urls[7] = file:/Users/pczuczor/.m2/repository/com/vaadin/external/gwt/gwt-elemental/2.8.2.vaadin2/gwt-elemental-2.8.2.vaadin2.jar
[ERROR] urls[8] = file:/Users/pczuczor/.m2/repository/com/vaadin/flow-commons-upload/24.2-SNAPSHOT/flow-commons-upload-24.2-SNAPSHOT.jar
[ERROR] urls[9] = file:/Users/pczuczor/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.15.2/jackson-core-2.15.2.jar
[ERROR] urls[10] = file:/Users/pczuczor/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.15.2/jackson-databind-2.15.2.jar
[ERROR] urls[11] = file:/Users/pczuczor/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.15.2/jackson-annotations-2.15.2.jar
[ERROR] urls[12] = file:/Users/pczuczor/.m2/repository/com/fasterxml/jackson/datatype/jackson-datatype-jsr310/2.15.2/jackson-datatype-jsr310-2.15.2.jar
[ERROR] urls[13] = file:/Users/pczuczor/.m2/repository/org/jsoup/jsoup/1.16.1/jsoup-1.16.1.jar
[ERROR] urls[14] = file:/Users/pczuczor/.m2/repository/com/helger/ph-css/7.0.1/ph-css-7.0.1.jar
[ERROR] urls[15] = file:/Users/pczuczor/.m2/repository/com/helger/commons/ph-commons/11.1.0/ph-commons-11.1.0.jar
[ERROR] urls[16] = file:/Users/pczuczor/.m2/repository/org/ow2/asm/asm/9.5/asm-9.5.jar
[ERROR] urls[17] = file:/Users/pczuczor/.m2/repository/com/vaadin/external/gentyref/1.2.0.vaadin1/gentyref-1.2.0.vaadin1.jar
[ERROR] urls[18] = file:/Users/pczuczor/.m2/repository/org/apache/commons/commons-compress/1.23.0/commons-compress-1.23.0.jar
[ERROR] urls[19] = file:/Users/pczuczor/.m2/repository/com/vaadin/license-checker/1.12.3/license-checker-1.12.3.jar
[ERROR] urls[20] = file:/Users/pczuczor/.m2/repository/com/github/oshi/oshi-core/6.4.1/oshi-core-6.4.1.jar
[ERROR] urls[21] = file:/Users/pczuczor/.m2/repository/net/java/dev/jna/jna/5.13.0/jna-5.13.0.jar
[ERROR] urls[22] = file:/Users/pczuczor/.m2/repository/net/java/dev/jna/jna-platform/5.13.0/jna-platform-5.13.0.jar
[ERROR] urls[23] = file:/Users/pczuczor/.m2/repository/com/nimbusds/nimbus-jose-jwt/9.31/nimbus-jose-jwt-9.31.jar
[ERROR] urls[24] = file:/Users/pczuczor/.m2/repository/org/lucee/jcip-annotations/1.0.0/jcip-annotations-1.0.0.jar
[ERROR] urls[25] = file:/Users/pczuczor/.m2/repository/org/reflections/reflections/0.10.2/reflections-0.10.2.jar
[ERROR] urls[26] = file:/Users/pczuczor/.m2/repository/org/javassist/javassist/3.28.0-GA/javassist-3.28.0-GA.jar
[ERROR] urls[27] = file:/Users/pczuczor/.m2/repository/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar
[ERROR] urls[28] = file:/Users/pczuczor/.m2/repository/org/zeroturnaround/zt-exec/1.12/zt-exec-1.12.jar
[ERROR] urls[29] = file:/Users/pczuczor/.m2/repository/com/google/gwt/gwt-elemental/2.9.0/gwt-elemental-2.9.0.jar
[ERROR] urls[30] = file:/Users/pczuczor/.m2/repository/org/codehaus/plexus/plexus-build-api/1.2.0/plexus-build-api-1.2.0.jar
[ERROR] urls[31] = file:/Users/pczuczor/.m2/repository/org/codehaus/plexus/plexus-utils/4.0.0/plexus-utils-4.0.0.jar
[ERROR] urls[32] = file:/Users/pczuczor/.m2/repository/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar
[ERROR] urls[33] = file:/Users/pczuczor/.m2/repository/com/vaadin/flow-polymer2lit/24.2-SNAPSHOT/flow-polymer2lit-24.2-SNAPSHOT.jar
[ERROR] urls[34] = file:/Users/pczuczor/.m2/repository/commons-io/commons-io/2.13.0/commons-io-2.13.0.jar
[ERROR] urls[35] = file:/Users/pczuczor/.m2/repository/org/apache/commons/commons-text/1.10.0/commons-text-1.10.0.jar
[ERROR] urls[36] = file:/Users/pczuczor/.m2/repository/org/apache/commons/commons-lang3/3.12.0/commons-lang3-3.12.0.jar
[ERROR] urls[37] = file:/Users/pczuczor/.m2/repository/org/jboss/forge/roaster/roaster-api/2.29.0.Final/roaster-api-2.29.0.Final.jar
[ERROR] urls[38] = file:/Users/pczuczor/.m2/repository/org/jboss/forge/roaster/roaster-jdt/2.29.0.Final/roaster-jdt-2.29.0.Final.jar
[ERROR] urls[39] = file:/Users/pczuczor/.m2/repository/com/vaadin/vaadin-prod-bundle/24.2-SNAPSHOT/vaadin-prod-bundle-24.2-SNAPSHOT.jar
[ERROR] urls[40] = file:/Users/pczuczor/.m2/repository/com/vaadin/vaadin-dev-bundle/24.2-SNAPSHOT/vaadin-dev-bundle-24.2-SNAPSHOT.jar
[ERROR] urls[41] = file:/Users/pczuczor/.m2/repository/com/vaadin/vaadin-dev-server/24.2-SNAPSHOT/vaadin-dev-server-24.2-SNAPSHOT.jar
[ERROR] urls[42] = file:/Users/pczuczor/.m2/repository/com/vaadin/open/8.5.0/open-8.5.0.jar
[ERROR] urls[43] = file:/Users/pczuczor/.m2/repository/com/github/javaparser/javaparser-core/3.25.5/javaparser-core-3.25.5.jar
[ERROR] urls[44] = file:/Users/pczuczor/.m2/repository/io/methvin/directory-watcher/0.18.0/directory-watcher-0.18.0.jar
[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import  from realm ClassRealm[maven.api, parent: null]]

[czp13]

With the help of @mshabarov , the error was fixed with changing in the pom.xml: vaadin-maven-plugin to flow-maven-plugin

Also the assumption was correct, and we have now the ExperimentalFeatureException:

 [qtp1388625705-86] ERROR com.vaadin.flow.server.DefaultErrorHandler - 
com.vaadin.flow.ai.formfiller.ExperimentalFeatureException: The Form Filler add-on is currently an experimental feature and needs to be explicitly enabled. It may be removed, altered, or limited to commercial subscribers in future releases. The add-on can be enabled using the Vaadin Dev Tools window, in the experimental features tab, or by adding a `src/main/resources/vaadin-featureflags.properties` file with the following content: `com.vaadin.experimental.formFillerAddon=true`

[mshabarov]

Thanks @czp13 for testing it. We need to wait a bit until a new platform snapshot 24.2-SNAPSHOT is available, then re-run the validation build.