vaadin / form-filler-addon

Other
4 stars 0 forks source link

chore: rework what we consider a supported component with this change (we will check attributes values as well) #124

Closed czp13 closed 1 year ago

czp13 commented 1 year ago

Description

Refactor, change what we consider supported component for auto fill.

Type of change

Checklist

Additional for Feature type of change

czp13 commented 1 year ago

All cases need to be tested (by me).

czp13 commented 1 year ago

I have tested and works, waiting for approvals now 🙇 .

czp13 commented 1 year ago

I believe and hope the review comments were fixed. 🙇 Could you approve pls if you are good with the fixes? 🙏

czp13 commented 1 year ago

Looks good to me. About unit tests, would you add a unit test here or add it to within another PR #104 ? I would add this to a separate PR if possible and sounds good to you! 🙇