fix: filling values for ComboBoxes and MultiSelectComboboxes. (#128) (CP: 0.1) - Githubissues

vaadin / form-filler-addon

Other

4 stars 0 forks source link

fix: filling values for ComboBoxes and MultiSelectComboboxes. (#128) (CP: 0.1) #130

Closed czp13 closed 1 year ago

czp13 commented 1 year ago

Description

Cherry-pick from:

128

---From previous PR---- Based on Slack discussions (Leif's suggestions): values can only be AI-filled into ComboBoxes and MultiSelectComboBoxes, if:

The values are already present in the items list OR
The values aren't in the items list, but the 'allow custom values' option is set to true.

Fixes # (issue)

https://github.com/vaadin/form-filler-addon/issues/125

Type of change

[x] Bugfix
[ ] Feature

Checklist

[x] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
[x] I have added a description following the guideline.
[x] The issue is created in the corresponding repository and I have referenced it.
[x] I have added tests to ensure my change is effective and works as intended.
[x] New and existing tests are passing locally with my change.
[x] I have performed self-review and corrected misspellings.

Additional for `Feature` type of change

[x] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.