vaadin / framework

Vaadin 6, 7, 8 is a Java framework for modern Java web applications.
http://vaadin.com/
Other
1.78k stars 729 forks source link

Vaadin resources publish issue in OSGI environment #10526

Open arotnov opened 6 years ago

arotnov commented 6 years ago

When vaadin resources bundles (e.g. vaadin-server, vaadin-themes, vaadin-client-compiled) starts before vaadin-shared, an exception "Vaadin Shared is not active!" is raised, and resources will not been published until bundles restart. Maybe its would be better to publish vaadin resources (resources in VAADIN folder, like bootstrap.js) as well as themes and widgetsets (through OSGI services).

Vaadin Framework version: 8.2.0 OSGI Environment: Apache Karaf 4.1.4

arotnov commented 6 years ago

By the way, its very strange to see OsgiVaadinResources class in its current implementation for OSGI purposes, while all publish works are doing by VaadinResourceService and VaadinResourceTrackerComponent (whiteboard pattern).

stale[bot] commented 6 years ago

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

elmot commented 6 years ago

Still valid

ZheSun88 commented 6 years ago

hi, recently, we have quite a few changes on this related issue. Could you test your project with the new released framework version 8.6.0.alpha2? Thanks.

arotnov commented 6 years ago

hi, recently, we have quite a few changes on this related issue. Could you test your project with the new released framework version 8.6.0.alpha2? Thanks.

Yes. I will test it during this week.

arotnov commented 6 years ago

I perform tests with Apache Karaf 4.2.1 and Pax Web 7.2.3: Then vaadin-shared bundle starts earlier than other resource contribution bundles (vaadin-server, themes, push) - no resources are published by http service. Then vaadin-shared starts after resouce contribution bundles, resources are published. Custom themes and widgetsets (contributed by OsgiVaadinTheme and OsgiVaadinWidgetset services) are also not published after starting of vaadin-shared (after activation of VaadinOsgiTrackerComponent). I think a problem is in resource registration logic in VaadinOsgiTrackerComponent - resources are actually registered only in activate() method, called once - when HttpService is binded to component.

ZheSun88 commented 6 years ago

still valid.

Maurice-Betzel commented 6 years ago

I do a programmatic restart of the Vaadin shared bundle if i detect undeployed servlets in my Karaf container as a workaround.

TatuLund commented 5 years ago

Is this problem still with 8.6.3?

arotnov commented 5 years ago

With 8.6.3 resources registraction (by OsgiVaadinContributor) works normal with any startup level. Ploblem is still valid for VaadinServlet whiteboard registraction (provided by osgi-integration bundle).

stale[bot] commented 5 years ago

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

TatuLund commented 5 years ago

Has this been retested with Vaadin 8.9?

stale[bot] commented 4 years ago

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!