Open mpittkin opened 6 years ago
Hello there!
We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.
There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):
Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!
FileDownloader is hooked at the browser level, so the shortcut doesn't work, but the clickEvent is triggered when you click on the button or use the shortcut, its only the file download that is not triggered on using the shortcut. I think that is more of a missing feature than a bug. If there is need for that I would suggest creating a new issue requesting the feature of shortcut support on FileDownloader.
Hello there!
We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.
There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):
Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!
Hello there!
We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.
There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):
Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!
Found using Chrome, Vaadin 8.4.3, Wildfly 10.1
To reproduce create a Button and add a keyboard shortcut using something like:
Button btnDownload = new Button(VaadinIcons.DOWNLOAD, event -> System.out.println("download")); btnDownload.setClickShortcut(KeyCode.P, ModifierKey.CTRL);
The button (if you added a click listener) is triggered when you click it or press Ctrl-P. Then take out the click handler and extend with FileDownloader:
Button btnDownload = new Button(VaadinIcons.DOWNLOAD); btnDownload.setClickShortcut(KeyCode.P, ModifierKey.CTRL); StreamResource downloadResource = getDownloadResource(); FileDownloader fileDownloader = new FileDownloader(downloadResource); fileDownloader.extend(btnDownload);
The download works if you click the button, but it no longer works if you press Ctrl-P.