Grid Edit row gets misaligned horizontally when tabbing out from a ComboBox while suggest box is open

[petrixh]

To make sure we can quickly validate and fix the bug, please provide as much as possible of the following information:

• Vaadin Framework version: 8.7.0 (also originally observed in 8.1.2)
• Browser version: OS X Chrome Version 72.0.3626.96 (Official Build) (64-bit)
• Web container name and version: Jetty and Tomcat 8
• Description of the bug

When the grid editor row is open and a user tabs out of a ComboBox that is close to the right edge, the editor cells get misaligned relative to the columns. The Save and Cancel buttons also get miss aligned when this happens.

Tracked it down to the case where the "suggest box" is open while the user presses the Tab-key and the Grid has to scroll horizontally in order to bring the next cell into view. Additionally, figured out that this happens because the ComboBox has a event.stopPropagation() in the client-side key handler. Tested as a workaround to add

if (event.getNativeKeyCode() != KeyCodes.KEY_TAB) { event.stopPropagation(); }

around it (line 2164-2166 in VComboBox in example code) which seems to fix the problem with Grid, however not sure what this will break elsewhere.

• Minimal reproducible example See included maven project, uncomment lines 2164 and 2166 in VComboBox to observe proper behaviour.
• Expected behavior The Grid should render correctly
• Actual behavior The cells are misaligned and the Save and Cancel buttons start to wander from right to left.

[petrixh]

grid-editor-combo-missalignment.zip

[stale[bot]]

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

• Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
• Provide more details how to reproduce the issue.
• Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
• Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
• Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
• If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

[TatuLund]

@petrixh have you tried GridEditorColumnFix, it has bunch of Editor column width issue fixing logic and could potentially remedy this issue also.

[stale[bot]]

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

• Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
• Provide more details how to reproduce the issue.
• Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
• Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
• Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
• If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!