Ensure vaadin-compatibility-client is OSGi compatible

Legioth commented 5 years ago

According to https://vaadin.com/forum/thread/17756874/vaadin-7-to-8-migration-vaadin-compatibility-client-not-osgi-compatible, the vaadin-compatibility-client is not OSGi compatible. Based on a quick look at MANIFEST.MF, it does indeed seem like the customary OSGi entires are missing.

TatuLund commented 5 years ago

I managed to get OSGi Vaadin portlet to work with Liferay 7 (ref the documentation https://vaadin.com/docs/v8/framework/portal/portal-osgi.html ) but in that experiment ) did use vaadin-compatibility-client-compiled instead. So probably manifest for it is correct. Need to cross check.

stale[bot] commented 4 years ago

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
Provide more details how to reproduce the issue.
Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

chrisnaan commented 3 years ago

I've created PR#12422 to add the OSGI entries to the manifest.

vaadin / framework

Ensure vaadin-compatibility-client is OSGi compatible #11660