search

vaadin / framework

Vaadin 6, 7, 8 is a Java framework for modern Java web applications.
http://vaadin.com/
Other
1.77k stars 728 forks source link

chore: avoid repackaging of google elemental dep and use it directly #12416

Closed denis-anisimov closed 2 years ago

denis-anisimov commented 2 years ago

The google elemental dependency is not OSGi compatible so it's repackaged into shared module to use it directly from there. But there is a custom Vaadin version of google elemental dep and it's OSGi compatible. Flow uses this version and to be able to use FW in MPR the versions should match. So the Vaadin google elemental dep is added instead of repackaging.

Thanks for submitting a pull request! Please confirm that your pull request follows our guidelines found in CONTRIBUTING and that you provide enough information so that we can review your pull request.

<Description of pull request, e.g. "Fix Grid Column not sortable with backend data and sort property">

Fixes #

Check when you have completed [ ] Valid tests for the pull request [ ] Contributing guidelines implemented

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

rkovarik commented 2 years ago

This change is not visible from https://vaadin.com/download/release/8.14/8.14.2/release-notes.html. We used to have gwt-elemental as provided dependency so it was not brought into webapps, causing ClassNotFoundExceptions after upgrade.