Fix for setting dataproviders when overriding getDataProvider

vaadin / framework

Vaadin 6, 7, 8 is a Java framework for modern Java web applications.

http://vaadin.com/

Other

1.77k stars 728 forks source link

Fix for setting dataproviders when overriding getDataProvider #12421

Closed pinneri closed 2 years ago

pinneri commented 2 years ago

Fixes #12394

Do not call an overridable method from the constructor.

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Ivano Pinneri seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

TatuLund commented 2 years ago

Thanks for your contribution.

This PR is created against wrong branch. We will collect all the contributions to master branch first. And after that we do pick them in release branch. Moreover 8.13 release branch is no longer in use.

Also this one needs more study before acceptance as well as a unit test would be preferable.