search

vaadin / framework

Vaadin 6, 7, 8 is a Java framework for modern Java web applications.
http://vaadin.com/
Other
1.77k stars 728 forks source link

Bundle compatibility client for OSGI #12422

Open chrisnaan opened 2 years ago

chrisnaan commented 2 years ago

Added to maven build to add OSGI manifest entries.

Fixes #11660

Check when you have completed [ x] Valid tests for the pull request [ x] Contributing guidelines implemented

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

TatuLund commented 2 years ago

Thank you for the contribution.

In the pom.xml line 53 seems to be code formatting issue, perhaps you used tabs instead of spaces.

TatuLund commented 2 years ago

@chrisnaan Thanks for quick action.

I am curious to know, are you using OSGi with Liferay or Karaf ?

chrisnaan commented 2 years ago

@chrisnaan Thanks for quick action.

I am curious to know, are you using OSGi with Liferay or Karaf ?

We're using Liferay DXP 7.3, we have some legacy Vaadin 7 code we need to get working on Liferay 7.3

chrisnaan commented 2 years ago

@TatuLund I don't think this is ready to merge yet, as there are dependencies this module uses that aren't osgi modules either.