vaadin / framework

Vaadin 6, 7, 8 is a Java framework for modern Java web applications.
http://vaadin.com/
Other
1.78k stars 730 forks source link

fix: Ensure that side effects of readBean does not set hasChanges true #12455

Closed TatuLund closed 2 years ago

TatuLund commented 2 years ago

JavaDoc of hasChanges says

"Check whether any of the bound fields' have uncommitted changes since last explicit call to {@link #readBean(Object)}, {@link #removeBean()}, * {@link #writeBean(Object)} or {@link #writeBeanIfValid(Object)}."

If readBean has converters, they will be run and field values updated accordingly. Furthermore if fields have value change listeners that will produce further changes in values, this should be considered according to above as part of readBean producedure and thus hasChanges still should return false.

fixes: https://github.com/vaadin/framework/issues/9581