search

vaadin / framework

Vaadin 6, 7, 8 is a Java framework for modern Java web applications.
http://vaadin.com/
Other
1.77k stars 729 forks source link

Failing non-OSGi portlets on Liferay CE 7.4.3.5 GA5 or later #12505

Open mikke-alekstra opened 2 years ago

mikke-alekstra commented 2 years ago

I did some non-OSGi testing with latest Vaadin framework git branch that supports latest Liferay kernel version, 29.0.1.

The portlet was a simple war-file containing the web.xml, portlet.xml, liferay-display.xml, liferay-portlet.xml, liferay-plugin-package.properties and one java-class extending Vaadin's UI class.

The used Vaadin version was a self compiled 8.15-SNAPSHOT from Vaadin framework's github's master branch that contained support for Liferay kernel 29.0.1.

Browser cache/history was cleared between each test.

Liferay versions that passed i.e. the simple portlet appeared as expected: Liferay CE 7.3.4 GA5 Liferay CE 7.3.5 GA6 Liferay CE 7.3.6 GA7 Liferay CE 7.3.7 GA8 Liferay CE 7.4.0 GA1 Liferay CE 7.4.1 GA2 Liferay CE 7.4.2 GA3 Liferay CE 7.4.3.4 GA4

The two newest Liferay releases failed i.e. the simple portlet did not appear: Liferay CE 7.4.3.5 GA5 (released 2021-12-28) Liferay CE 7.4.3.6 GA6 (released 2022-01-06)

There were no errors in browser nor in Liferay log files.

It looked like UI's protected void init(VaadinRequest request) was never called.

Setup: Debian GNU/Linux 10 (buster) OpenJDK 11 Firefox 78.15.0esr Standard Liferay Docker images

TatuLund commented 2 years ago

I again thank you for very valuable work on investigating this.

This result is clearly better than https://github.com/vaadin/framework/issues/12504

And looks like that problem in the other ticket is almost certainly OSGi related.

TatuLund commented 2 years ago

Liferay CE 7.4.3.6 GA6 (released 2022-01-06)

This should be easy to fix by just updating kernel version dependency.

mikke-alekstra commented 2 years ago

It is probably not a kernel version dependency issue with 7.4.3.6 GA6. I compiled the Vaadin snapshot with dependency for 7.4.3.5 GA5 kernel version and kernel version had not updated in 7.4.3.6 GA6.

But... There is now also 7.4.3.7 GA7 (released 2022-01-14) with kernel version 30.1.1 and that is out of the range. Liferay used to publish new CE releases not more than a few times a year but as far as I have understood they have changed their way of publishing to smaller releases published within short intervals.

Anyway, I think that kernel version might not be the reason with non-OSGi problems with CE 7.4.3.5 GA5 and 7.4.3.6 GA6.