search

vaadin / framework

Vaadin 6, 7, 8 is a Java framework for modern Java web applications.
http://vaadin.com/
Other
1.77k stars 729 forks source link

License checker in Framework 8.16.0 incompatible with the one in 23.1.3 #12549

Closed enver-haase closed 1 year ago

enver-haase commented 1 year ago

To make sure we can quickly validate and fix the bug, please provide as much as possible of the following information:

Using MPR and 8.16 and 23.1.3, it depends on the CLASSPATH order whether or not the system can come up.

Consider

    Caused by: java.lang.NoSuchMethodError: 'void com.vaadin.pro.licensechecker.LicenseChecker.setStrictOffline(boolean)'
        at com.vaadin.base.devserver.startup.DevModeInitializer.initDevModeHandler(DevModeInitializer.java:208)
        at com.vaadin.base.devserver.DevModeHandlerManagerImpl.initDevModeHandler(DevModeHandlerManagerImpl.java:80)
        at com.vaadin.base.devserver.startup.DevModeStartupListener.initialize(DevModeStartupListener.java:74)
        at com.vaadin.flow.server.startup.VaadinServletContextStartupInitializer.process(VaadinServletContextStartupInitializer.java:42)

where said method does not exist in the 8.16.0 version of LicenseChecker.java .

NOTE THE PROBLEM MAY OR MAY NOT SHOW. I did not witness it in Linux, not in Windows either. I reckon it is a classpath order thing.

The most simple MPR project with said versions should show the problem.

Running up the system for a paying customer at least, validating the license okay

Exception as above

enver-haase commented 1 year ago

Proposal: at least in Vaadin 8, make the License Checker a Maven module (jar file) so it can be excluded from the classpath. And DOCUMENT THIS for setting up an MPR project.

IDEA says that 8.1.6 has its own version of LicenseChecker.java in "vaadin-server:8.16.0" in the JAR.

TatuLund commented 1 year ago

This will be fixed in in Vaadin 8.16.1.

mshabarov commented 1 year ago

@TatuLund shall we move this issue into framework repo?

TatuLund commented 1 year ago

Vaadin 8.16.1 has been released.

shall we move this issue into framework repo?

Could be more appropriate place.

TatuLund commented 1 year ago

Fixed by https://github.com/vaadin/framework-es/pull/40