Closed rPraml closed 1 year ago
I am pleased to see that our are able to detect details like this. This check is done only assertions (as we are doing many other checkings that can have performance impact), so this should not be a concern.
, if assertions are enabled, but disabling assertions is not really an option.
Do you mean that you run assertions enabled in production?
Hello Tatu, currently, we have enabled assertions in production. (and that's good - we are still investigating why #12565 happens). I know that enabling assertions may affect performance. We do not have vaadin 8.19 productive, yet. So I cannot say how the overall performance is affected by this particular code change. I only did a quick review what's changed between 8.18 and 8.19 and noticed, that there is a possible performance bottleneck, which can be easily fixed.
Improvement will be included in Vaadin 8.19.1
Affected version: Vaadin Framework 8.19.0
Hello, I compared the
vaadin-server
source changes 8.18.0 <-> 8.19.0 and noticed, that there are mostly changes, that look like this:I'm afraid, that this could cause a massive performance impact, if the
MprServlet
is not on the classpath, as every time an exception is generated and thrown. I see that this code may be executed multiple times per request. I see also that most code paths are only executed, if assertions are enabled, but disabling assertions is not really an option.I would suggest to cache the result, if
MprServlet
is present or not.Please see this test about performance results and a possible fix
cheers Roland