Bean Validation uses (wrong) default locale

[vaadin-bot]

Originally by DimitriL

---

Given is the code (also available in the attachment as a project):

First appearance of the fields shows the validation errors in the German language (see the screen shot) but the locale is set to UK. The reason is in the method of the AbstractComponent#getLocale() which returns null as the locale because the field is not yet attached to the parent, but the validator is already initialized with the default (wrong) locale.

public class ValidationUI extends UI {

    @Override
    protected void init(VaadinRequest request) {
        VaadinSession.getCurrent().setLocale(Locale.UK);
        setLocale(Locale.UK);

        final VerticalLayout layout = new VerticalLayout();
        layout.setMargin(true);
        setContent(layout);

        Project project = new Project();

        final TextField textField = new TextField("Name");
        textField.setNullRepresentation("");
        textField.setWidth("150px");

        final BeanFieldGroup<Project> fieldGroup = new BeanFieldGroup<Project>(Project.class);
        fieldGroup.setItemDataSource(project);
        fieldGroup.bind(textField, "name");

        FormLayout formLayout = new FormLayout(textField);
        formLayout.addComponent(textField);

        Button button = new Button("Click Me");
        button.addClickListener(new Button.ClickListener() {
            public void buttonClick(ClickEvent event) {
                try {
                    layout.addComponent(new Label("Field Locale: " + textField.getLocale()));
                    fieldGroup.commit();
                } catch (CommitException e) {
                    throw new RuntimeException(e);
                }
            }
        });

        layout.addComponent(formLayout);
        layout.addComponent(button);
    }
}

---

Imported from https://dev.vaadin.com/ issue #12016

[vaadin-bot]

Originally by DimitriL

---

Attachment added: Validation.gif (9.6 KiB) https://trac-attachments.vaadin.com/trac/12016/Validation.gif

[vaadin-bot]

Originally by DimitriL

---

Attachment added: Validation.zip (12.7 KiB)

[vaadin-bot]

Originally by @hesara

---

For a workaround see https://vaadin.com/old-forum/-/message_boards/view_message/3366235 .

Getting the correct locale for validation on the framework is somewhat more complicated, though - maybe it should come from each field to its validators so that setting the locale for a field or a layout would keep consistency between validators and fields.

[vaadin-bot]

Originally by oehme

---

I think this should have a priority, as the "workaround" is a mess and only works on commit. BeanValidation is basically useless without the correct locale.

Validators should probably have a reference to their field, so that they can use "getLocale" at validation time.

[vaadin-bot]

Originally by DimitriL

---

I think it would be even ok to take the locale from the UI. UI.getCurrent()...

[stale[bot]]

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

• Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
• Provide more details how to reproduce the issue.
• Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
• Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
• Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
• If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!