search

vaadin / framework

Vaadin 6, 7, 8 is a Java framework for modern Java web applications.
http://vaadin.com/
Other
1.78k stars 729 forks source link

Mention Coding Conventions in the development instructions #7252

Open vaadin-bot opened 9 years ago

vaadin-bot commented 9 years ago

Originally by @magi42

Setting up the Eclipse project preferences and the coding conventions files is not mentioned in the README.md for the Vaadin Framework project at https://github.com/vaadin/vaadin.

Such instructions should probably be in the "Set up extra workspace preferences" section. Please check if there's something else missing as well. The old instructions are at https://dev.vaadin.com/wiki/CodingConventions.

Perhaps this should be mentioned in the Contributing Code page as well.

Imported from https://dev.vaadin.com/ issue #19155

pleku commented 7 years ago

Now with github workflow, we should do this ASAP so we don't get PRs with code that is not formatted the way we want to.

Main thing is to describe what should be done in Eclipse after importing the project before.

stale[bot] commented 6 years ago

A lot of tickets have been left hanging in the issue tracker through the years. Some of them are still relevant, some of them have been fixed a long time ago and some are no longer valid. To get a better look on what is important and still relevant, we are closing old tickets which have not been touched in a long time. No further work will be done on this ticket. If the ticket seems to be still actual, please verify the problem existence over latest framework version and then open a new ticket in vaadin/framework with all the suitable information.