Unnecessary liferay session extension

[vmodrosedem]

Currently, vaadin extends Liferay session for logged-in users after each request (Added as a fix for issue #8305). This sends a request to /c/portal/extend_session after each vaadin request.

But this session extension is not needed when liferay is configured to automatically extend session (session.timeout.auto.extend=true setting in portal-ext.properties). With autoExtend set to true, the liferay session never expires as long as the browser window remains open. Liferay client side code automatically extends it before it expires. In this case, extending liferay session after each request only wastes resources.

I propose that the session extension should not be called when autoExtend is true. This flag can be retrieved on the client side using: $wnd.Liferay.Session.get('autoExtend').

Related resources: https://github.com/vaadin/framework/blob/588f3cc7f8f719a6bd38b4c196fce80c8040b44c/client/src/main/java/com/vaadin/client/communication/MessageSender.java#L303

https://github.com/liferay/liferay-portal/blob/master/modules/apps/foundation/frontend-js/frontend-js-web/src/main/resources/META-INF/resources/liferay/session.js https://github.com/liferay/liferay-portal/blob/master/portal-web/docroot/html/common/themes/session_timeout.jspf

Versions: Vaadin 7.7.6 Liferay Portal Enterprise Edition 6.2.10 EE GA1

[stale[bot]]

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

• Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
• Provide more details how to reproduce the issue.
• Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
• Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
• Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
• If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

[stale[bot]]

The issue was automatically closed due to inactivity. If you found some new details to it or started working on it, comment on the issue so that maintainers can re-open it.