vaadin / hilla

Build better business applications, faster. No more juggling REST endpoints or deciphering GraphQL queries. Hilla seamlessly connects Spring Boot and React to accelerate application development.
https://hilla.dev
Apache License 2.0
879 stars 57 forks source link

Wrong example for SQL Authentication #2078

Open krissvaa opened 5 months ago

krissvaa commented 5 months ago

SQL Authentication example in Hilla docs doesn't work as @Override protected void configure(AuthenticationManagerBuilder auth) as such method doesn't exist in VaadinWebSecurity

https://hilla.dev/docs/lit/guides/security/spring-login#sql-authentication (same for LDAP)

Could be that it was a mistake and Default Spring implementation should be used? https://spring.io/blog/2022/02/21/spring-security-without-the-websecurityconfigureradapter#jdbc-authentication

platosha commented 5 months ago

Could be that it was a mistake and Default Spring implementation should be used?

I think so. There should be nothing Hilla specific in setting up AuthenticationManager with an SQL database.

platosha commented 5 months ago

This example can be based directly on Spring Security, or even be replaced with a link to the Spring Security documentation.