vaadin / hilla

Build better business applications, faster. No more juggling REST endpoints or deciphering GraphQL queries. Hilla seamlessly connects Spring Boot and React to accelerate application development.
https://hilla.dev
Apache License 2.0
867 stars 58 forks source link

refactor(lit-form): deprecate AbstractModel methods that require BinderNode #2522

Open Lodin opened 1 month ago

Lodin commented 1 month ago

Resolves #2060.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.65%. Comparing base (c4dc4c2) to head (aed078f).

Files Patch % Lines
packages/ts/lit-form/src/Validation.ts 0.00% 0 Missing and 2 partials :warning:
packages/ts/lit-form/src/Models.ts 90.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2522 +/- ## ========================================== - Coverage 90.81% 90.65% -0.17% ========================================== Files 66 66 Lines 2765 2771 +6 Branches 528 531 +3 ========================================== + Hits 2511 2512 +1 - Misses 79 82 +3 - Partials 175 177 +2 ``` | [Flag](https://app.codecov.io/gh/vaadin/hilla/pull/2522/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/vaadin/hilla/pull/2522/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin) | `90.65% <75.00%> (-0.17%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vaadin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud